Cleaned up Lockable

context.go

@@ -582,16 +582,6 @@ func NewContext(db * badger.DB, log Logger) (*Context, error) {
     return nil, err
   }
 
-  req_info_type := reflect.TypeOf(ReqInfo{})
-  req_info_info, err := GetStructInfo(ctx, req_info_type)
-  if err != nil {
-    return nil, err
-  }
-  err = ctx.RegisterType(req_info_type, ReqInfoType, nil, SerializeStruct(req_info_info), nil, DeserializeStruct(req_info_info))
-  if err != nil {
-    return nil, err
-  }
-
   err = ctx.RegisterExtension(reflect.TypeOf((*LockableExt)(nil)), LockableExtType, nil)
   if err != nil {
     return nil, err

gql.go

@@ -1389,7 +1389,7 @@ func NewGQLExtContext() *GQLExtContext {
       "requirements",
       LockableExtType,
       func(p graphql.ResolveParams, ctx *ResolveContext, value reflect.Value) ([]NodeID, error) {
-        id_strs, ok := value.Interface().(map[NodeID]ReqInfo)
+        id_strs, ok := value.Interface().(map[NodeID]ReqState)
         if ok == false {
           return nil, fmt.Errorf("can't parse requirements %+v as map[NodeID]ReqState", value.Type())
         }

lockable.go

@@ -2,6 +2,7 @@ package graphvent
 
 import (
   "github.com/google/uuid"
+  "time"
 )
 
 type ReqState byte
@@ -13,9 +14,12 @@ const (
   AbortingLock = ReqState(4)
 )
 
-type ReqInfo struct {
+var ReqStateStrings = map[ReqState]string {
-  State ReqState `gv:"state"`
+  Unlocked: "Unlocked",
-  MsgID uuid.UUID `gv:"msg_id"`
+  Unlocking: "Unlocking",
+  Locked: "Locked",
+  Locking: "Locking",
+  AbortingLock: "AbortingLock",
 }
 
 type LockableExt struct{
@@ -24,7 +28,8 @@ type LockableExt struct{
   Owner *NodeID `gv:"owner"`
   PendingOwner *NodeID `gv:"pending_owner"`
   PendingID uuid.UUID `gv:"pending_id"`
-  Requirements map[NodeID]ReqInfo `gv:"requirements"`
+  Requirements map[NodeID]ReqState `gv:"requirements"`
+  WaitInfos WaitMap `gv:"wait_infos"`
 }
 
 func (ext *LockableExt) Type() ExtType {
@@ -32,14 +37,11 @@ func (ext *LockableExt) Type() ExtType {
 }
 
 func NewLockableExt(requirements []NodeID) *LockableExt {
-  var reqs map[NodeID]ReqInfo = nil
+  var reqs map[NodeID]ReqState = nil
   if requirements != nil {
-    reqs = map[NodeID]ReqInfo{}
+    reqs = map[NodeID]ReqState{}
     for _, id := range(requirements) {
-      reqs[id] = ReqInfo{
+      reqs[id] = Unlocked
-        Unlocked,
-        uuid.UUID{},
-      }
     }
   }
   return &LockableExt{
@@ -47,6 +49,7 @@ func NewLockableExt(requirements []NodeID) *LockableExt {
     Owner: nil,
     PendingOwner: nil,
     Requirements: reqs,
+    WaitInfos: WaitMap{},
   }
 }
 
@@ -65,34 +68,32 @@ func LockLockable(ctx *Context, node *Node) (uuid.UUID, error) {
 }
 
 func (ext *LockableExt) HandleErrorSignal(ctx *Context, node *Node, source NodeID, signal *ErrorSignal) (Messages, Changes) {
-  str := signal.Error
   var messages Messages = nil
   var changes Changes = nil
-  switch str {
+
-  case "not_unlocked":
+  info, info_found := node.ProcessResponse(ext.WaitInfos, signal)
-    changes = changes.Add("requirements")
+  if info_found {
-    if ext.State == Locking {
+    state, found := ext.Requirements[info.NodeID]
+    if found == true {
+      ctx.Log.Logf("lockable", "got mapped response %+v for %+v in state %s", signal, info, ReqStateStrings[state])
+      switch state {
+      case Locking:
         ext.State = AbortingLock
-      req_info := ext.Requirements[source]
+        ext.Requirements[info.NodeID] = Unlocked
-      req_info.State = Unlocked
+        for id, state := range(ext.Requirements) {
-      ext.Requirements[source] = req_info
+          if state == Locked {
-      for id, info := range(ext.Requirements) {
+            ext.Requirements[id] = Unlocking
-        if info.State == Locked {
             lock_signal := NewLockSignal("unlock")
-
+            ext.WaitInfos[lock_signal.Id] = node.QueueTimeout(id, lock_signal, 100*time.Millisecond)
-          req_info := ext.Requirements[id]
-          req_info.State = Unlocking
-          req_info.MsgID = lock_signal.ID()
-          ext.Requirements[id] = req_info
-          ctx.Log.Logf("lockable", "SENT_ABORT_UNLOCK: %s to %s", lock_signal.ID(), id)
-
             messages = messages.Add(ctx, id, node, nil, lock_signal)
+            ctx.Log.Logf("lockable", "sent abort unlock to %s from %s", id, node.ID)
+          }
         }
+      case Unlocking:
       }
+    } else {
+      ctx.Log.Logf("lockable", "Got mapped error %s, but %s isn't a requirement", signal, info.NodeID)
     }
-  case "not_locked":
-    panic("RECEIVED not_locked, meaning a node thought it held a lock it didn't")
-  case "not_requirement":
   }
 
   return messages, changes
@@ -109,12 +110,9 @@ func (ext *LockableExt) HandleLinkSignal(ctx *Context, node *Node, source NodeID
         messages = messages.Add(ctx, source, node, nil, NewErrorSignal(signal.ID(), "already_requirement"))
       } else {
         if ext.Requirements == nil {
-          ext.Requirements = map[NodeID]ReqInfo{}
+          ext.Requirements = map[NodeID]ReqState{}
-        }
-        ext.Requirements[signal.NodeID] = ReqInfo{
-          Unlocked,
-          uuid.UUID{},
         }
+        ext.Requirements[signal.NodeID] = Unlocked
         changes = changes.Add("requirement_added")
         messages = messages.Add(ctx, source, node, nil, NewSuccessSignal(signal.ID()))
       }
@@ -143,27 +141,25 @@ func (ext *LockableExt) HandleSuccessSignal(ctx *Context, node *Node, source Nod
     return messages, changes
   }
 
-  info, found := ext.Requirements[source]
+  info, info_found := node.ProcessResponse(ext.WaitInfos, signal)
+  if info_found == true {
+    state, found := ext.Requirements[info.NodeID]
     if found == false {
-    ctx.Log.Logf("lockable", "Got success from non-requirement %s", source)
+      ctx.Log.Logf("lockable", "Got success signal for requirement that is no longer in the map(%s), ignoring...", info.NodeID)
-  } else if info.MsgID != signal.ReqID {
-    ctx.Log.Logf("lockable", "Got success for wrong signal for %s: %s, expecting %s", source, signal.ReqID, info.MsgID)
     } else {
-    if info.State == Locking {
+      ctx.Log.Logf("lockable", "got mapped response %+v for %+v in state %s", signal, info, ReqStateStrings[state])
-      if ext.State == Locking {
+      switch state {
-        info.State = Locked
+      case Locking:
-        info.MsgID = uuid.UUID{}
+        switch ext.State {
-        ext.Requirements[source] = info
+        case Locking:
-        reqs := 0
+          ext.Requirements[info.NodeID] = Locked
           locked := 0
           for _, s := range(ext.Requirements) {
-          reqs += 1
+            if s == Locked {
-          if s.State == Locked {
               locked += 1
             }
           }
-
+          if locked == len(ext.Requirements) {
-        if locked == reqs {
             ctx.Log.Logf("lockable", "WHOLE LOCK: %s - %s - %+v", node.ID, ext.PendingID, ext.PendingOwner)
             ext.State = Locked
             ext.Owner = ext.PendingOwner
@@ -171,29 +167,31 @@ func (ext *LockableExt) HandleSuccessSignal(ctx *Context, node *Node, source Nod
             messages = messages.Add(ctx, *ext.Owner, node, nil, NewSuccessSignal(ext.PendingID))
           } else {
             changes = changes.Add("partial_lock")
-          ctx.Log.Logf("lockable", "PARTIAL LOCK: %s - %d/%d", node.ID, locked, reqs)
+            ctx.Log.Logf("lockable", "PARTIAL LOCK: %s - %d/%d", node.ID, locked, len(ext.Requirements))
           }
-      } else if ext.State == AbortingLock {
+        case AbortingLock:
+          ext.Requirements[info.NodeID] = Unlocking
+
           lock_signal := NewLockSignal("unlock")
-        info.State = Unlocking
+          ext.WaitInfos[lock_signal.Id] = node.QueueTimeout(info.NodeID, lock_signal, 100*time.Millisecond)
-        info.MsgID = lock_signal.ID()
+          messages = messages.Add(ctx, info.NodeID, node, nil, lock_signal)
-        ext.Requirements[source] = info
+
-        messages = messages.Add(ctx, source, node, nil, lock_signal)
+          ctx.Log.Logf("lockable", "sending abort_lock to %s for %s", info.NodeID, node.ID)
-      }
+        }
-    } else if info.State == Unlocking {
+      case AbortingLock:
-      info.State = Unlocked
+        ctx.Log.Logf("lockable", "Got success signal in AbortingLock %s", node.ID)
-      info.MsgID = uuid.UUID{}
+        fallthrough
-      ext.Requirements[source] = info
+      case Unlocking:
-      reqs := 0
+        ext.Requirements[source] = Unlocked
+
         unlocked := 0
         for _, s := range(ext.Requirements) {
-        reqs += 1
+          if s == Unlocked {
-        if s.State == Unlocked {
             unlocked += 1
           }
         }
 
-      if unlocked == reqs {
+        if unlocked == len(ext.Requirements) {
           old_state := ext.State
           ext.State = Unlocked
           ctx.Log.Logf("lockable", "WHOLE UNLOCK: %s - %s - %+v", node.ID, ext.PendingID, ext.PendingOwner)
@@ -210,7 +208,8 @@ func (ext *LockableExt) HandleSuccessSignal(ctx *Context, node *Node, source Nod
           }
         } else {
           changes = changes.Add("partial_unlock")
-        ctx.Log.Logf("lockable", "PARTIAL UNLOCK: %s - %d/%d", node.ID, unlocked, reqs)
+          ctx.Log.Logf("lockable", "PARTIAL UNLOCK: %s - %d/%d", node.ID, unlocked, len(ext.Requirements))
+        }
       }
     }
   }
@@ -225,7 +224,8 @@ func (ext *LockableExt) HandleLockSignal(ctx *Context, node *Node, source NodeID
 
   switch signal.State {
   case "lock":
-    if ext.State == Unlocked {
+    switch ext.State {
+    case Unlocked:
       if len(ext.Requirements) == 0 {
         ext.State = Locked
         new_owner := source
@@ -241,19 +241,21 @@ func (ext *LockableExt) HandleLockSignal(ctx *Context, node *Node, source NodeID
         ext.PendingOwner = &new_owner
         ext.PendingID = signal.ID()
         changes = changes.Add("locking")
-        for id, info := range(ext.Requirements) {
+        for id, state := range(ext.Requirements) {
-          if info.State != Unlocked {
+          if state != Unlocked {
             ctx.Log.Logf("lockable", "REQ_NOT_UNLOCKED_WHEN_LOCKING")
           }
+
           lock_signal := NewLockSignal("lock")
-          info.State = Locking
+          ext.WaitInfos[lock_signal.Id] = node.QueueTimeout(id, lock_signal, 100*time.Millisecond)
-          info.MsgID = lock_signal.ID()
+          ext.Requirements[id] = Locking
-          ext.Requirements[id] = info
+
           messages = messages.Add(ctx, id, node, nil, lock_signal)
         }
       }
-    } else {
+    default:
       messages = messages.Add(ctx, source, node, nil, NewErrorSignal(signal.ID(), "not_unlocked"))
+      ctx.Log.Logf("lockable", "Tried to lock %s while locked", node.ID)
     }
   case "unlock":
     if ext.State == Locked {
@@ -271,14 +273,15 @@ func (ext *LockableExt) HandleLockSignal(ctx *Context, node *Node, source NodeID
         ext.PendingOwner = nil
         ext.PendingID = signal.ID()
         changes = changes.Add("unlocking")
-        for id, info := range(ext.Requirements) {
+        for id, state := range(ext.Requirements) {
-          if info.State != Locked {
+          if state != Locked {
             ctx.Log.Logf("lockable", "REQ_NOT_LOCKED_WHEN_UNLOCKING")
           }
+
           lock_signal := NewLockSignal("unlock")
-          info.State = Unlocking
+          ext.WaitInfos[lock_signal.Id] = node.QueueTimeout(id, lock_signal, 100*time.Millisecond)
-          info.MsgID = lock_signal.ID()
+          ext.Requirements[id] = Unlocking
-          ext.Requirements[id] = info
+
           messages = messages.Add(ctx, id, node, nil, lock_signal)
         }
       }
@@ -291,6 +294,24 @@ func (ext *LockableExt) HandleLockSignal(ctx *Context, node *Node, source NodeID
   return messages, changes
 }
 
+func (ext *LockableExt) HandleTimeoutSignal(ctx *Context, node *Node, source NodeID, signal *TimeoutSignal) (Messages, Changes) {
+  var messages Messages = nil
+  var changes Changes = nil
+
+  //TODO: Handle timeout errors better
+  wait_info, found := node.ProcessResponse(ext.WaitInfos, signal)
+  if found == true {
+    state, found := ext.Requirements[wait_info.NodeID]
+    if found == true {
+      ctx.Log.Logf("lockable", "%s timed out %s", wait_info.NodeID, ReqStateStrings[state])
+    } else {
+      ctx.Log.Logf("lockable", "%s timed out", wait_info.NodeID)
+    }
+  }
+
+  return messages, changes
+}
+
 // LockableExts process Up/Down signals by forwarding them to owner, dependency, and requirement nodes
 // LockSignal and LinkSignal Direct signals are processed to update the requirement/dependency/lock state
 func (ext *LockableExt) Process(ctx *Context, node *Node, source NodeID, signal Signal) (Messages, Changes) {
@@ -320,6 +341,8 @@ func (ext *LockableExt) Process(ctx *Context, node *Node, source NodeID, signal
       messages, changes = ext.HandleErrorSignal(ctx, node, source, sig)
     case *SuccessSignal:
       messages, changes = ext.HandleSuccessSignal(ctx, node, source, sig)
+    case *TimeoutSignal:
+      messages, changes = ext.HandleTimeoutSignal(ctx, node, source, sig)
     default:
     }
   default:

lockable_test.go

@@ -51,11 +51,11 @@ func TestLink(t *testing.T) {
   _, _, err = WaitForResponse(l1_listener.Chan, time.Millisecond*10, link_signal.ID())
   fatalErr(t, err)
 
-  info, exists := l1_lockable.Requirements[l2.ID]
+  state, exists := l1_lockable.Requirements[l2.ID]
   if exists == false {
     t.Fatal("l2 not in l1 requirements")
-  } else if info.State != Unlocked {
+  } else if state != Unlocked {
-    t.Fatalf("l2 in bad requirement state in l1: %+v", info.State)
+    t.Fatalf("l2 in bad requirement state in l1: %+v", state)
   }
 
   msgs = Messages{}
@@ -68,8 +68,8 @@ func TestLink(t *testing.T) {
   fatalErr(t, err)
 }
 
-func Test10KLink(t *testing.T) {
+func Test100Lock(t *testing.T) {
-  ctx := lockableTestContext(t, []string{"test"})
+  ctx := lockableTestContext(t, []string{"test", "lockable"})
 
   l_pub, listener_key, err := ed25519.GenerateKey(rand.Reader)
   fatalErr(t, err)
@@ -87,7 +87,7 @@ func Test10KLink(t *testing.T) {
     return l
   }
 
-  reqs := make([]NodeID, 1000)
+  reqs := make([]NodeID, 100)
   for i := range(reqs) {
     new_lockable := NewLockable()
     reqs[i] = new_lockable.ID
@@ -152,7 +152,7 @@ func TestLock(t *testing.T) {
 
   id_2, err := LockLockable(ctx, l1)
   fatalErr(t, err)
-  _, _, err = WaitForResponse(l1_listener.Chan, time.Millisecond*10, id_2)
+  _, _, err = WaitForResponse(l1_listener.Chan, time.Millisecond*100, id_2)
   fatalErr(t, err)
 
   id_3, err := UnlockLockable(ctx, l0)

serialize.go

@@ -256,7 +256,6 @@ var (
   MapType       = NewSerializedType("MAP")
 
   ReqStateType         = NewSerializedType("REQ_STATE")
-  ReqInfoType          = NewSerializedType("REQ_INFO")
   WaitInfoType         = NewSerializedType("WAIT_INFO")
   SignalDirectionType  = NewSerializedType("SIGNAL_DIRECTION")
   NodeStructType       = NewSerializedType("NODE_STRUCT")

serialize_test.go

@@ -10,9 +10,9 @@ import (
 func TestSerializeTest(t *testing.T) {
   ctx := logTestContext(t, []string{"test", "serialize", "deserialize_types"})
   testSerialize(t, ctx, map[string][]NodeID{"test_group": {RandID(), RandID(), RandID()}})
-  testSerialize(t, ctx, map[NodeID]ReqInfo{
+  testSerialize(t, ctx, map[NodeID]ReqState{
-    RandID(): {},
+    RandID(): Locked,
-    RandID(): {},
+    RandID(): Unlocked,
   })
 }