Merge pull request #3655 from myk002/myk_banner

[BannerPanel] use square brackets instead of color blocks

docs/changelog.txt

@@ -60,6 +60,7 @@ Template for new versions:
 - Core: properly reload scripts in mods when a world is unloaded and immediately loaded again
 
 ## Misc Improvements
+- Surround DFHack-specific UI elements with square brackets instead of red-yellow blocks for better readability
 - `hotkeys`: don't display DFHack logo in legends mode since it covers up important interface elements. the Ctrl-Shift-C hotkey to bring up the menu and the mouseover hotspot still function, though.
 
 ## Documentation

library/lua/gui/widgets.lua

@@ -1511,13 +1511,11 @@ end
 
 BannerPanel = defclass(BannerPanel, Panel)
 
-local BANNER_PEN = dfhack.pen.parse{fg=COLOR_YELLOW, bg=COLOR_RED}
-
 function BannerPanel:onRenderBody(dc)
-    dc:pen(BANNER_PEN)
+    dc:pen(COLOR_RED)
     for y=0,self.frame_rect.height-1 do
-        dc:seek(0, y):char(string.char(221)) -- half-width stripe on left
-        dc:seek(self.frame_rect.width-1):char(string.char(222)) -- half-width stripe on right
+        dc:seek(0, y):char('[')
+        dc:seek(self.frame_rect.width-1):char(']')
     end
 end