Merge pull request #2437 from myk002/myk_ctest

Combine unit testing branches and simplify

.github/workflows/build.yml

@@ -96,8 +96,13 @@ jobs:
       run: |
         ninja -C build-ci install
         ccache --show-stats
-    - name: Run tests
+    - name: Run cpp unit tests
-      id: run_tests
+      id: run_tests_cpp
+      run: |
+        ninja -C build-ci test
+        exit $?
+    - name: Run lua tests
+      id: run_tests_lua
       run: |
         export TERM=dumb
         status=0

.gitignore

@@ -29,6 +29,8 @@ build/Makefile
 build/CMakeCache.txt
 build/cmake_install.cmake
 build/CMakeFiles
+build/CTestTestfile.cmake
+build/DartConfiguration.tcl
 build/data
 build/docs
 build/lua

.gitmodules

@@ -28,3 +28,6 @@
 [submodule "depends/luacov"]
 	path = depends/luacov
 	url = ../../DFHack/luacov.git
+[submodule "depends/googletest"]
+	path = depends/googletest
+	url = ../../google/googletest.git

CMakeLists.txt

@@ -421,6 +421,16 @@ include_directories(depends/clsocket/src)
 include_directories(depends/xlsxio/include)
 add_subdirectory(depends)
 
+# Testing with CTest
+macro(dfhack_test name files)
+    message("dfhack_test(${name}, ${files})")
+    add_executable(${name} ${files})
+    target_include_directories(${name} PUBLIC depends/googletest/googletest/include)
+    target_link_libraries(${name} dfhack gtest SDL)
+    add_test(NAME ${name} COMMAND ${name})
+endmacro()
+include(CTest)
+
 find_package(Git REQUIRED)
 if(NOT GIT_FOUND)
     message(SEND_ERROR "could not find git")

depends/CMakeLists.txt

@@ -3,6 +3,8 @@ add_subdirectory(lodepng)
 add_subdirectory(lua)
 add_subdirectory(md5)
 add_subdirectory(protobuf)
+add_subdirectory(googletest)
+set_target_properties(gtest PROPERTIES COMPILE_FLAGS "-Wno-maybe-uninitialized -Wno-sign-compare")
 
 # Don't build tinyxml if it's being externally linked against.
 if(NOT TinyXML_FOUND)

depends/googletest

@@ -0,0 +1 @@
+Subproject commit 2fe3bd994b3189899d93f1d5a881e725e046fdc2

library/CMakeLists.txt

@@ -82,6 +82,11 @@ set(MAIN_SOURCES
     RemoteTools.cpp
 )
 
+file(GLOB_RECURSE TEST_SOURCES
+    LIST_DIRECTORIES false
+    *test.cpp)
+dfhack_test(dfhack-test "${TEST_SOURCES}")
+
 if(WIN32)
     set(CONSOLE_SOURCES Console-windows.cpp)
 else()

library/MiscUtils.test.cpp

@@ -0,0 +1,19 @@
+
+#include "MiscUtils.h"
+#include <gtest/gtest.h>
+#include <string>
+
+TEST(MiscUtils, wordwrap) {
+    std::vector<std::string> result;
+
+    word_wrap(&result, "123", 3);
+    ASSERT_EQ(result.size(), 1);
+
+    result.clear();
+    word_wrap(&result, "123456", 3);
+    ASSERT_EQ(result.size(), 2);
+
+    result.clear();
+    word_wrap(&result, "1234567", 3);
+    ASSERT_EQ(result.size(), 3);
+}

library/main.test.cpp

@@ -0,0 +1,6 @@
+#include <gtest/gtest.h>
+
+int main(int argc, char **argv) {
+    ::testing::InitGoogleTest(&argc, argv);
+    return RUN_ALL_TESTS();
+}