Creature traits, added back map occupancy.

dfhack/include/modules/Creatures.h

@@ -296,6 +296,7 @@ namespace DFHack
         uint8_t numLikes;
         t_like likes[32];
         */
+        uint16_t traits[NUM_CREATURE_TRAITS];
         t_attrib analytical_ability;
         t_attrib focus;
         t_attrib willpower;

dfhack/include/modules/Maps.h

@@ -197,14 +197,14 @@ namespace DFHack
 
     typedef int16_t tiletypes40d [16][16];
     typedef DFHack::t_designation designations40d [16][16];
-//    typedef DFHack::t_occupancy occupancies40d [16][16];
+    typedef DFHack::t_occupancy occupancies40d [16][16];
     typedef uint8_t biome_indices40d [16];
 
     typedef struct
     {
         tiletypes40d tiletypes;
         designations40d designation;
-//        occupancies40d occupancy;
+        occupancies40d occupancy;
         biome_indices40d biome_indices;
         uint32_t origin; // the address where it came from
         t_blockflags blockflags;
@@ -290,11 +290,10 @@ namespace DFHack
         bool ReadDesignations(uint32_t blockx, uint32_t blocky, uint32_t blockz, designations40d *buffer);
         bool WriteDesignations (uint32_t blockx, uint32_t blocky, uint32_t blockz, designations40d *buffer);
 
-        /*
         /// read/write block occupancies
         bool ReadOccupancy(uint32_t blockx, uint32_t blocky, uint32_t blockz, occupancies40d *buffer);
         bool WriteOccupancy(uint32_t blockx, uint32_t blocky, uint32_t blockz, occupancies40d *buffer);
-*/
+
         /// read/write the block dirty bit - this is used to mark a map block so that DF scans it for designated jobs like digging
         bool ReadDirtyBit(uint32_t blockx, uint32_t blocky, uint32_t blockz, bool &dirtybit);
         bool WriteDirtyBit(uint32_t blockx, uint32_t blocky, uint32_t blockz, bool dirtybit);

dfhack/modules/Creatures.cpp

@@ -86,6 +86,7 @@ Creatures::Creatures(APIPrivate* _d)
         // soul offsets
         creatures.soul_skills_vector_offset = minfo->getOffset("soul_skills_vector");
         creatures.soul_mental_offset = minfo->getOffset("soul_mental");
+        creatures.soul_traits_offset = minfo->getOffset("soul_traits");
         
         // name offsets for the creature module
         creatures.name_firstname_offset = minfo->getOffset("name_firstname");
@@ -219,10 +220,11 @@ bool Creatures::ReadCreature (const int32_t index, t_creature & furball)
         furball.defaultSoul.skills[i].rating = g_pProcess->readByte (temp2 + 4);
         furball.defaultSoul.skills[i].experience = g_pProcess->readWord (temp2 + 8);
     }
-    g_pProcess->read(temp + offs.soul_mental_offset, sizeof(t_attrib) * 13, (uint8_t *)&furball.defaultSoul.analytical_ability);
+    // mental attributes are part of the soul
+    g_pProcess->read(soul + offs.soul_mental_offset, sizeof(t_attrib) * 13, (uint8_t *)&furball.defaultSoul.analytical_ability);
     
-    // traits
+    // traits as well
-    //g_pProcess->read (temp + offs.creature_traits_offset, sizeof (uint16_t) * NUM_CREATURE_TRAITS, (uint8_t *) &furball.traits);
+    g_pProcess->read(soul + offs.soul_traits_offset, sizeof (uint16_t) * NUM_CREATURE_TRAITS, (uint8_t *) &furball.defaultSoul.traits);
     
     //likes
     /*

dfhack/modules/Maps.cpp

@@ -156,6 +156,14 @@ bool Maps::Start()
     return true;
 }
 
+// getter for map size
+void Maps::getSize (uint32_t& x, uint32_t& y, uint32_t& z)
+{
+    x = d->x_block_count;
+    y = d->y_block_count;
+    z = d->z_block_count;
+}
+
 bool Maps::Finish()
 {
     if (d->block != NULL)
@@ -166,6 +174,10 @@ bool Maps::Finish()
     return true;
 }
 
+/*
+ * Block reading
+ */
+
 bool Maps::isValidBlock (uint32_t x, uint32_t y, uint32_t z)
 {
     if ( x >= d->x_block_count || y >= d->y_block_count || z >= d->z_block_count)
@@ -200,6 +212,7 @@ bool Maps::ReadBlock40d(uint32_t x, uint32_t y, uint32_t z, mapblock40d * buffer
         {
             g_pProcess->read (addr + d->offsets.tile_type_offset, sizeof (buffer->tiletypes), (uint8_t *) buffer->tiletypes);
             g_pProcess->read (addr + d->offsets.designation_offset, sizeof (buffer->designation), (uint8_t *) buffer->designation);
+            g_pProcess->read (addr + d->offsets.occupancy_offset, sizeof (buffer->occupancy), (uint8_t *) buffer->occupancy);
             g_pProcess->read (addr + d->offsets.biome_stuffs, sizeof (biome_indices40d), (uint8_t *) buffer->biome_indices);
             buffer->origin = addr;
             uint32_t addr_of_struct = g_pProcess->readDWord(addr);
@@ -210,8 +223,10 @@ bool Maps::ReadBlock40d(uint32_t x, uint32_t y, uint32_t z, mapblock40d * buffer
     }
 }
 
+/*
+ * Tiletypes
+ */ 
 
-// 256 * sizeof(uint16_t)
 bool Maps::ReadTileTypes (uint32_t x, uint32_t y, uint32_t z, tiletypes40d *buffer)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
@@ -223,6 +238,21 @@ bool Maps::ReadTileTypes (uint32_t x, uint32_t y, uint32_t z, tiletypes40d *buff
     return false;
 }
 
+bool Maps::WriteTileTypes (uint32_t x, uint32_t y, uint32_t z, tiletypes40d *buffer)
+{
+    uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
+    if (addr)
+    {
+        g_pProcess->write (addr + d->offsets.tile_type_offset, sizeof (tiletypes40d), (uint8_t *) buffer);
+        return true;
+    }
+    return false;
+}
+
+/*
+ * Dirty flags
+ */ 
+
 bool Maps::ReadDirtyBit(uint32_t x, uint32_t y, uint32_t z, bool &dirtybit)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
@@ -274,6 +304,10 @@ bool Maps::WriteBlockFlags(uint32_t x, uint32_t y, uint32_t z, t_blockflags bloc
     return false;
 }
 
+/*
+ * Designations
+ */ 
+
 bool Maps::ReadDesignations (uint32_t x, uint32_t y, uint32_t z, designations40d *buffer)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
@@ -285,35 +319,46 @@ bool Maps::ReadDesignations (uint32_t x, uint32_t y, uint32_t z, designations40d
     return false;
 }
 
-// 256 * sizeof(uint16_t)
+bool Maps::WriteDesignations (uint32_t x, uint32_t y, uint32_t z, designations40d *buffer)
-bool Maps::WriteTileTypes (uint32_t x, uint32_t y, uint32_t z, tiletypes40d *buffer)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
     if (addr)
     {
-        g_pProcess->write (addr + d->offsets.tile_type_offset, sizeof (tiletypes40d), (uint8_t *) buffer);
+        g_pProcess->write (addr + d->offsets.designation_offset, sizeof (designations40d), (uint8_t *) buffer);
         return true;
     }
     return false;
 }
 
+/*
+ * Occupancies
+ */ 
 
-// 256 * sizeof(uint32_t)
+bool Maps::ReadOccupancy (uint32_t x, uint32_t y, uint32_t z, occupancies40d *buffer)
-bool Maps::WriteDesignations (uint32_t x, uint32_t y, uint32_t z, designations40d *buffer)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
     if (addr)
     {
-        g_pProcess->write (addr + d->offsets.designation_offset, sizeof (designations40d), (uint8_t *) buffer);
+        g_pProcess->read (addr + d->offsets.occupancy_offset, sizeof (occupancies40d), (uint8_t *) buffer);
         return true;
     }
     return false;
 }
 
-// FIXME: this is bad. determine the real size!
+bool Maps::WriteOccupancy (uint32_t x, uint32_t y, uint32_t z, occupancies40d *buffer)
-//16 of them? IDK... there's probably just 7. Reading more doesn't cause errors as it's an array nested inside a block
+{
-// 16 * sizeof(uint8_t)
+    uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
+    if (addr)
+    {
+        g_pProcess->write (addr + d->offsets.occupancy_offset, sizeof (tiletypes40d), (uint8_t *) buffer);
+        return true;
+    }
+    return false;
+}
 
+/*
+ * Region Offsets - used for layer geology
+ */ 
 bool Maps::ReadRegionOffsets (uint32_t x, uint32_t y, uint32_t z, biome_indices40d *buffer)
 {
     uint32_t addr = d->block[x*d->y_block_count*d->z_block_count + y*d->z_block_count + z];
@@ -325,8 +370,9 @@ bool Maps::ReadRegionOffsets (uint32_t x, uint32_t y, uint32_t z, biome_indices4
     return false;
 }
 
-
+/*
-// veins of a block, expects empty vein vectors
+ * Block events
+ */ 
 bool Maps::ReadVeins(uint32_t x, uint32_t y, uint32_t z, vector <t_vein>* veins, vector <t_frozenliquidvein>* ices, vector <t_spattervein> *splatter)
 {
     t_vein v;
@@ -408,14 +454,6 @@ try_again:
     return false;
 }
 
-// getter for map size
-void Maps::getSize (uint32_t& x, uint32_t& y, uint32_t& z)
-{
-    x = d->x_block_count;
-    y = d->y_block_count;
-    z = d->z_block_count;
-}
-
 /*
 __int16 __userpurge GetGeologicalRegion<ax>(__int16 block_X<cx>, int X<ebx>, __int16 block_Y<di>, int block_addr<esi>, int Y)
 {
@@ -471,7 +509,9 @@ __int16 __userpurge GetGeologicalRegion<ax>(__int16 block_X<cx>, int X<ebx>, __i
 }
 */
 
-//vector<uint16_t> v_geology[eBiomeCount];
+/*
+ * Layer geology
+ */
 bool Maps::ReadGeology (vector < vector <uint16_t> >& assign)
 {
     memory_info * minfo = d->d->offset_descriptor;
@@ -479,8 +519,6 @@ bool Maps::ReadGeology (vector < vector <uint16_t> >& assign)
     int region_x_offset = minfo->getAddress ("region_x");
     int region_y_offset = minfo->getAddress ("region_y");
     int region_z_offset =  minfo->getAddress ("region_z");
-/*    <Address name="geoblock_vector">0x16AF52C</Address>
-    <Address name="ptr2_region_array">0x16AF574</Address>*/
     int world_regions =  minfo->getAddress ("ptr2_region_array");
     int region_size =  minfo->getHexValue ("region_size");
     int region_geo_index_offset =  minfo->getOffset ("region_geo_index_off");

dfhack/shm/mod-creature2010.h

@@ -58,6 +58,7 @@ typedef struct
     uint32_t name_nickname_offset;
     uint32_t name_words_offset;
     uint32_t soul_mental_offset;
+    uint32_t soul_traits_offset;
 } creature_offsets;
 
 typedef struct

examples/creaturedump.cpp

@@ -10,6 +10,7 @@ using namespace std;
 #include <DFTypes.h>
 #include <DFHackAPI.h>
 #include <DFMemInfo.h>
+#include <DFProcess.h>
 #include <modules/Materials.h>
 #include <modules/Creatures.h>
 #include <modules/Translation.h>
@@ -270,6 +271,15 @@ void printCreature(DFHack::API & DF, const DFHack::t_creature & creature)
             cout << laborname << ", ";
         }
         cout << endl;
+        
+        cout << "Traits" << endl;
+        for(uint32_t i = 0; i < 30;i++)
+        {
+            string trait = mem->getTrait (i, creature.defaultSoul.traits[i]);
+            if(!trait.empty())
+                cout << trait << ", ";
+        }
+        cout << endl;
         /*
          * FLAGS 1
          */