MetzNet
/
dfhack
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adapt to review comments by @PatrikLundell 

- survey.cpp: rename loop variable for more clarity; replace use of parmeter with use of vector.size(), replace nested vector.at calls with direct index access/subscript as it is faster and easier to read
develop
bseiller 2021-02-03 14:32:03 +01:00
parent 0c304cf85f
commit 52bf998224
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
plugins/embark-assistant/survey.cpp
Unescape Escape View File

@ -902,14 +902,15 @@ void embark_assist::survey::high_level_world_survey(embark_assist::defs::geo_dat
//================================================================================= //=================================================================================
void reset_mlt_inorganics(embark_assist::defs::mid_level_tiles *mlts, const uint16_t max_inorganic) { void reset_mlt_inorganics(embark_assist::defs::mid_level_tiles &mlts) {
const uint16_t size = mlts[0][0].metals.size();
for (uint8_t i = 0; i < 16; i++) { for (uint8_t i = 0; i < 16; i++) {
for (uint8_t k = 0; k < 16; k++) { for (uint8_t k = 0; k < 16; k++) {
embark_assist::defs::mid_level_tile &mlt = mlts->at(i).at(k); embark_assist::defs::mid_level_tile &mlt = mlts[i][k];
for (uint16_t i = 0; i < max_inorganic; i++) { for (uint16_t l = 0; l < size; l++) {
mlt.metals[i] = false; mlt.metals[l] = false;
mlt.economics[i] = false; mlt.economics[l] = false;
mlt.minerals[i] = false; mlt.minerals[l] = false;
} }
} }
} }
@ -950,7 +951,7 @@ void embark_assist::survey::survey_mid_level_tile(embark_assist::defs::geo_data
tile->minerals[i] = 0; tile->minerals[i] = 0;
} }
reset_mlt_inorganics(mlt, state->max_inorganic); reset_mlt_inorganics(*mlt);
for (uint8_t i = 1; i < 10; i++) survey_results->at(x).at(y).biome_index[i] = -1; for (uint8_t i = 1; i < 10; i++) survey_results->at(x).at(y).biome_index[i] = -1;