MetzNet
/
dfhack
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

attempt to increase code readability 

following lethosor and myk's suggestions, each symbol now is its own constant with a descriptive name.
...will it work though?
develop
TaxiService 2023-04-01 16:43:05 +02:00 committed by GitHub
parent 18f1b5c675
commit 3a6893de53
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
library/modules/Items.cpp
Unescape Escape View File

@ -720,13 +720,18 @@ df::coord Items::getPosition(df::item *item)
return item->pos; return item->pos;
} }
static int quality_table[] = { 0, 45, 43, 42, 240, 15 }; static const char MARKER_EXCEPTIONAL = static_cast<char>(240);
static const char MARKER_MASTERWORK = static_cast<char>(15);
static const char MARKER_IMPROVED_LEFT = static_cast<char>(174);
static const char MARKER_IMPROVED_RIGHT = static_cast<char>(175);
static char quality_table[] = { 0, '-', '+', '*', MARKER_EXCEPTIONAL, MARKER_MASTERWORK };
static void addQuality(std::string &tmp, int quality) static void addQuality(std::string &tmp, int quality)
{ {
if (quality > 0 && quality <= 5) { if (quality > 0 && quality <= 5) {
int c = quality_table[quality]; char c = quality_table[quality];
tmp = static_cast<char>(c) + tmp + static_cast<char>(c); tmp = c + tmp + c;
} }
} }
@ -825,7 +830,7 @@ std::string Items::getDescription(df::item *item, int type, bool decorate)
addQuality(tmp, item->getQuality()); addQuality(tmp, item->getQuality());
if (item->isImproved()) { if (item->isImproved()) {
tmp = static_cast<char>(174) + tmp + static_cast<char>(175); tmp = MARKER_IMPROVED_LEFT + tmp + MARKER_IMPROVED_RIGHT;
addQuality(tmp, item->getImprovementQuality()); addQuality(tmp, item->getImprovementQuality());
} }
} }