MetzNet
/
dfhack
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adapt tests to dynamically-generated field info 

No need to freeze the field info tables anymore
develop
lethosor 2023-08-12 21:59:14 -04:00
parent fc6d4caa8e
commit 396b2d7832
No known key found for this signature in database
GPG Key ID: 76A269552F4F58C1
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
library/LuaTypes.cpp
Unescape Escape View File

@ -1403,7 +1403,6 @@ static void PushFieldInfoSubTable(lua_State *state, const struct_field_info *fie
Lua::TableInsert(state, "original_name", field->extra->original_name); Lua::TableInsert(state, "original_name", field->extra->original_name);
} }
} }
// freeze_table(state); // TODO: make pairs() work
} }
/** /**

15
test/structures/struct_fields.lua
Unescape Escape View File

@ -43,6 +43,13 @@ end
function test.nonexistent() function test.nonexistent()
expect.nil_(df.coord._fields.nonexistent) expect.nil_(df.coord._fields.nonexistent)
expect.error_match('string expected', function()
expect.nil_(df.coord._fields[2])
end)
expect.error_match('string expected', function()
expect.nil_(df.coord._fields[nil])
end)
end end
function test.readonly() function test.readonly()
@ -52,13 +59,11 @@ function test.readonly()
expect.error_match(READONLY_MSG, function() expect.error_match(READONLY_MSG, function()
df.coord._fields.nonexistent = 'foo' df.coord._fields.nonexistent = 'foo'
end) end)
-- see TODOs in LuaTypes.cpp expect.nil_(df.coord._fields.nonexistent)
-- expect.error_match(READONLY_MSG, function()
-- df.coord._fields.x.name = 'foo'
-- end)
-- should have no effect
df.coord._fields.x.name = 'foo'
expect.eq(df.coord._fields.x.name, 'x') expect.eq(df.coord._fields.x.name, 'x')
expect.nil_(df.coord._fields.nonexistent)
end end
function test.circular_refs_init() function test.circular_refs_init()