From f383f63eeaef7e0017e206ef76b40586f1cd88e8 Mon Sep 17 00:00:00 2001
From: Ben Lubar <ben.lubar@gmail.com>
Date: Fri, 21 Feb 2020 15:07:48 -0600
Subject: [PATCH] fix check-structures-sanity not catching certain types of
 invalid string on GCC builds.

update structures.
---
 library/xml                               | 2 +-
 plugins/devel/check-structures-sanity.cpp | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/library/xml b/library/xml
index 5e14929a0..c3835a548 160000
--- a/library/xml
+++ b/library/xml
@@ -1 +1 @@
-Subproject commit 5e14929a059671993b801a1d712c418ab6327a6a
+Subproject commit c3835a548baade596e422666872ec80134c024e1
diff --git a/plugins/devel/check-structures-sanity.cpp b/plugins/devel/check-structures-sanity.cpp
index 7d700e53a..d95c9b28c 100644
--- a/plugins/devel/check-structures-sanity.cpp
+++ b/plugins/devel/check-structures-sanity.cpp
@@ -689,6 +689,8 @@ void Checker::check_stl_string(const ToCheck & item)
 #else
     if (!check_access(item, string->ptr, item.identity, 1))
     {
+        // nullptr is NOT okay here
+        FAIL("invalid string pointer");
         return;
     }
     if (!check_access(item, string->ptr - 1, item.identity, sizeof(*string->ptr)))