From d8e440806c8ad617f29ff2b462d2c0ce407735d2 Mon Sep 17 00:00:00 2001 From: Myk Taylor Date: Wed, 22 Feb 2023 23:19:04 -0800 Subject: [PATCH] fix signed/unsigned compare --- plugins/buildingplan/defaultitemfilters.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/buildingplan/defaultitemfilters.cpp b/plugins/buildingplan/defaultitemfilters.cpp index 4cc6f11cf..36d074363 100644 --- a/plugins/buildingplan/defaultitemfilters.cpp +++ b/plugins/buildingplan/defaultitemfilters.cpp @@ -47,7 +47,7 @@ DefaultItemFilters::DefaultItemFilters(color_ostream &out, PersistentDataItem &f } void DefaultItemFilters::setItemFilter(DFHack::color_ostream &out, const ItemFilter &filter, int index) { - if (item_filters.size() <= index) { + if (index < 0 || item_filters.size() <= (size_t)index) { WARN(status,out).print("invalid index for filter key %d,%d,%d: %d\n", std::get<0>(key), std::get<1>(key), std::get<2>(key), index); return;