MetzNet
/
dfhack
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Protect against integer overflow when subtracting with action timer API

develop
Tachytaenius 2022-11-23 14:06:26 +00:00
parent 6148307e9b
commit cc40b80456
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
library/modules/Units.cpp
Unescape Escape View File

@ -2012,7 +2012,12 @@ void subtractActionTimerCore(df::unit_action *action, int32_t amount)
{
int32_t *timer = getActionTimerPointer(action);
if (timer != nullptr && *timer > 0) {
*timer = max(*timer - amount, 1);
double value = *timer;
value = max(value - amount, 1.0);
if (value > INT32_MAX) {
value = INT32_MAX;
}
*timer = value;
}
}