Merge remote-tracking branch 'suokko/lua_List_setChoices_internal_table_1171' into develop

docs/changelog.txt

@@ -146,6 +146,7 @@ changelog.txt uses a syntax similar to RST, with a few special sequences:
 ## Lua
 - Added ``profiler`` module to measure lua performance
 - Enabled shift+cursor movement in WorkshopOverlay-derived screens
+- ``gui.widgets``: ``List:setChoices`` clones ``choices`` for internal table changes
 
 ## Structures
 - ``unit_flags1``: renamed ``dead`` to ``inactive`` to better reflect its use

library/lua/gui/widgets.lua

@@ -456,15 +456,17 @@ function List:init(info)
 end
 
 function List:setChoices(choices, selected)
-    self.choices = choices or {}
+    self.choices = {}
 
-    for i,v in ipairs(self.choices) do
+    for i,v in ipairs(choices or {}) do
+        local l = utils.clone(v);
         if type(v) ~= 'table' then
-            v = { text = v }
-            self.choices[i] = v
+            l = { text = v }
+        else
+            l.text = v.text or v.caption or v[1]
         end
-        v.text = v.text or v.caption or v[1]
-        parse_label_text(v)
+        parse_label_text(l)
+        self.choices[i] = l
     end
 
     self:setSelected(selected)