From 9ca2eaa7940ddbad1b89804640a235c24f953612 Mon Sep 17 00:00:00 2001
From: lethosor <lethosor@gmail.com>
Date: Wed, 11 Aug 2021 21:54:05 -0400
Subject: [PATCH] Disable shallow clones in .gitmodules

Shallow clones cause issues with `git push --recurse-submodules=check|on-demand`
such as in https://github.com/DFHack/dfhack/runs/3307192897?check_suite_focus=true:

```
The following submodule paths contain changes that can
not be found on any remote:
  depends/luacov

Please try

    git push --recurse-submodules=on-demand

or cd to the path and use

    git push

to push them to a remote.
```

(in this case, the changes *are* on the remote, and on-demand doesn't help)

Our submodules also aren't currently very large on disk even with full clones -
libexpat is the largest:

616K    .git/modules/depends/clsocket
744K    .git/modules/depends/luacov
924K    .git/modules/depends/xlsxio
1.8M    .git/modules/depends/libzip
3.7M    .git/modules/depends/jsoncpp
8.2M    .git/modules/depends/libexpat

If a shallow clone of submodules is desired, `git clone --shallow-submodules` is
still an option.
---
 .gitmodules | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/.gitmodules b/.gitmodules
index 51ace0f41..9c5ac2d51 100644
--- a/.gitmodules
+++ b/.gitmodules
@@ -19,16 +19,12 @@
 [submodule "depends/xlsxio"]
 	path = depends/xlsxio
 	url = ../../DFHack/xlsxio.git
-	shallow = true
 [submodule "depends/libzip"]
 	path = depends/libzip
 	url = ../../DFHack/libzip.git
-	shallow = true
 [submodule "depends/libexpat"]
 	path = depends/libexpat
 	url = ../../DFHack/libexpat.git
-	shallow = true
 [submodule "depends/luacov"]
 	path = depends/luacov
 	url = ../../DFHack/luacov.git
-	shallow = true