From 85bfa60cf2744902ae978d0dfba79c9c260dd75f Mon Sep 17 00:00:00 2001 From: Ben Lubar Date: Sat, 29 Feb 2020 21:57:39 -0600 Subject: [PATCH] allow -1 union values for undefined tags to avoid false positives --- plugins/devel/check-structures-sanity.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/devel/check-structures-sanity.cpp b/plugins/devel/check-structures-sanity.cpp index 6dc4b7335..6e5f84860 100644 --- a/plugins/devel/check-structures-sanity.cpp +++ b/plugins/devel/check-structures-sanity.cpp @@ -724,7 +724,7 @@ void Checker::queue_union(const ToCheck & item, const ToCheck & tag_item) // if it's all uninitialized, ignore it uint8_t uninit_value = *reinterpret_cast(item.ptr); - bool all_uninitialized = uninit_value == 0 || uninit_value == 0xd2; + bool all_uninitialized = uninit_value == 0x00 || uninit_value == 0xd2 || uninit_value == 0xff; if (all_uninitialized) { for (size_t offset = 0; offset < union_type->byte_size(); offset++)