From 70a2ab91417281a39df2d26ab2ca2d654e4b58ff Mon Sep 17 00:00:00 2001 From: Alexander Gavrilov Date: Thu, 22 Aug 2013 11:22:18 +0400 Subject: [PATCH] Fix crash due to incorrect loop bounds in add-spatter. This caused a buffer overrun bug if an ADD_SPATTER reaction had any non-improvement outputs. --- plugins/add-spatter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/add-spatter.cpp b/plugins/add-spatter.cpp index ca37c8ee3..f7a611ec8 100644 --- a/plugins/add-spatter.cpp +++ b/plugins/add-spatter.cpp @@ -378,7 +378,7 @@ static bool find_reactions(color_ostream &out) parse_product(out, out_prod.back(), it->second.react, itprod); } - for (size_t i = 0; i < prod.size(); i++) + for (size_t i = 0; i < out_prod.size(); i++) { if (out_prod[i].isValid()) products[out_prod[i].product] = &out_prod[i];