From 441afcced51d0b9f2a829ff61068074785ad49ca Mon Sep 17 00:00:00 2001
From: lethosor <lethosor@gmail.com>
Date: Sat, 26 Sep 2015 13:28:06 -0400
Subject: [PATCH] Fix issues with detecting Sphinx

---
 CMakeLists.txt | 45 +++++++++++++++++++++++----------------------
 1 file changed, 23 insertions(+), 22 deletions(-)

diff --git a/CMakeLists.txt b/CMakeLists.txt
index 4f5d57e6a..40052048a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -10,7 +10,7 @@ else(CMAKE_CONFIGURATION_TYPES)
   endif (NOT CMAKE_BUILD_TYPE)
 endif(CMAKE_CONFIGURATION_TYPES)
 
-SET(BUILD_DOCS "True" CACHE STRING "Choose whether to build the documentation (requires python and Sphinx.")
+SET(BUILD_DOCS ON CACHE BOOL "Choose whether to build the documentation (requires python and Sphinx).")
 
 ## some generic CMake magic
 cmake_minimum_required(VERSION 2.8 FATAL_ERROR)
@@ -194,29 +194,30 @@ endif()
 
 add_subdirectory(scripts)
 
-#find_package(Sphinx REQUIRED)
 find_package(Sphinx)
 if (BUILD_DOCS)
-
-	set(SPHINX_THEME "alabaster")
-	set(SPHINX_THEME_DIR)
-	set(SPHINX_BINARY_BUILD_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/_build")
-	set(SPHINX_CACHE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/_build/_doctrees")
-	set(SPHINX_HTML_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/html/")
-
-	configure_file(
-		"${CMAKE_CURRENT_SOURCE_DIR}/docs/conf.py.in"
-		"${SPHINX_BINARY_BUILD_DIR}/conf.py"
-		@ONLY)
-
-	add_custom_target(dfhack_docs ALL
-		${SPHINX_EXECUTABLE}
-			-q -b html
-			-c "${SPHINX_BINARY_BUILD_DIR}"
-			-d "${SPHINX_CACHE_DIR}"
-			"${CMAKE_CURRENT_SOURCE_DIR}"
-			"${SPHINX_HTML_DIR}"
-		COMMENT "Building HTML documentation with Sphinx")
+  if (NOT SPHINX_FOUND)
+    message(SEND_ERROR "Sphinx not found but BUILD_DOCS enabled")
+  endif()
+  set(SPHINX_THEME "alabaster")
+  set(SPHINX_THEME_DIR)
+  set(SPHINX_BINARY_BUILD_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/_build")
+  set(SPHINX_CACHE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/_build/_doctrees")
+  set(SPHINX_HTML_DIR "${CMAKE_CURRENT_SOURCE_DIR}/docs/html/")
+
+  configure_file(
+    "${CMAKE_CURRENT_SOURCE_DIR}/docs/conf.py.in"
+    "${SPHINX_BINARY_BUILD_DIR}/conf.py"
+    @ONLY)
+
+  add_custom_target(dfhack_docs ALL
+    ${SPHINX_EXECUTABLE}
+      -q -b html
+      -c "${SPHINX_BINARY_BUILD_DIR}"
+      -d "${SPHINX_CACHE_DIR}"
+      "${CMAKE_CURRENT_SOURCE_DIR}"
+      "${SPHINX_HTML_DIR}"
+    COMMENT "Building HTML documentation with Sphinx")
     install(DIRECTORY ${dfhack_SOURCE_DIR}/docs/html
         DESTINATION ${DFHACK_USERDOC_DESTINATION}
         #FILES_MATCHING PATTERN "*.lua"