2020-06-29 22:29:30 -06:00
|
|
|
#!/usr/bin/env python3
|
2015-02-14 17:59:17 -07:00
|
|
|
import re, os, sys
|
|
|
|
|
|
|
|
valid_extensions = ['c', 'cpp', 'h', 'hpp', 'mm', 'lua', 'rb', 'proto',
|
2015-03-04 15:33:12 -07:00
|
|
|
'init', 'init-example', 'rst']
|
2015-02-14 17:59:17 -07:00
|
|
|
path_blacklist = [
|
2015-02-23 16:44:19 -07:00
|
|
|
'^library/include/df/',
|
|
|
|
'^plugins/stonesense/allegro',
|
|
|
|
'^plugins/isoworld/allegro',
|
|
|
|
'^plugins/isoworld/agui',
|
|
|
|
'^depends/',
|
|
|
|
'^.git/',
|
|
|
|
'^build',
|
|
|
|
'.pb.h',
|
2015-02-14 17:59:17 -07:00
|
|
|
]
|
|
|
|
|
|
|
|
def valid_file(filename):
|
2015-04-06 09:25:30 -06:00
|
|
|
return len(list(filter(lambda ext: filename.endswith('.' + ext), valid_extensions))) and \
|
|
|
|
not len(list(filter(lambda path: path.replace('\\', '/') in filename.replace('\\', '/'), path_blacklist)))
|
2015-02-14 17:59:17 -07:00
|
|
|
|
|
|
|
success = True
|
2020-06-29 21:58:47 -06:00
|
|
|
def error(msg=None):
|
2015-02-14 17:59:17 -07:00
|
|
|
global success
|
|
|
|
success = False
|
2020-06-29 21:58:47 -06:00
|
|
|
if msg:
|
|
|
|
sys.stderr.write(msg + '\n')
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2020-06-29 21:58:47 -06:00
|
|
|
def format_lines(lines, total):
|
|
|
|
if len(lines) == total - 1:
|
|
|
|
return 'entire file'
|
|
|
|
if not len(lines):
|
|
|
|
# should never happen
|
|
|
|
return 'nowhere'
|
|
|
|
if len(lines) == 1:
|
|
|
|
return 'line %i' % lines[0]
|
|
|
|
s = 'lines '
|
|
|
|
range_start = range_end = lines[0]
|
|
|
|
for i, line in enumerate(lines):
|
|
|
|
if line > range_end + 1:
|
|
|
|
if range_start == range_end:
|
|
|
|
s += ('%i, ' % range_end)
|
|
|
|
else:
|
|
|
|
s += ('%i-%i, ' % (range_start, range_end))
|
|
|
|
range_start = range_end = line
|
|
|
|
if i == len(lines) - 1:
|
|
|
|
s += ('%i' % line)
|
|
|
|
else:
|
|
|
|
range_end = line
|
|
|
|
if i == len(lines) - 1:
|
|
|
|
s += ('%i-%i, ' % (range_start, range_end))
|
|
|
|
return s.rstrip(' ').rstrip(',')
|
|
|
|
|
|
|
|
class LinterError(Exception):
|
|
|
|
def __init__(self, message, lines, total_lines):
|
|
|
|
self.message = message
|
|
|
|
self.lines = lines
|
|
|
|
self.total_lines = total_lines
|
|
|
|
|
|
|
|
def __str__(self):
|
|
|
|
return '%s: %s' % (self.message, format_lines(self.lines, self.total_lines))
|
|
|
|
|
|
|
|
def github_actions_workflow_command(self, filename):
|
|
|
|
first_line = self.lines[0] if self.lines else 1
|
|
|
|
return '::error file=%s,line=%i::%s' % (filename, first_line, self)
|
2015-02-14 17:59:17 -07:00
|
|
|
|
|
|
|
class Linter(object):
|
2016-02-01 07:39:40 -07:00
|
|
|
ignore = False
|
2015-02-14 17:59:17 -07:00
|
|
|
def check(self, lines):
|
|
|
|
failures = []
|
|
|
|
for i, line in enumerate(lines):
|
|
|
|
if not self.check_line(line):
|
2015-02-14 19:43:10 -07:00
|
|
|
failures.append(i + 1)
|
2015-02-14 17:59:17 -07:00
|
|
|
if len(failures):
|
2020-06-29 21:58:47 -06:00
|
|
|
raise LinterError(self.msg, failures, len(lines))
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2015-02-14 20:25:10 -07:00
|
|
|
def fix(self, lines):
|
|
|
|
for i in range(len(lines)):
|
|
|
|
lines[i] = self.fix_line(lines[i])
|
|
|
|
|
2015-02-14 17:59:17 -07:00
|
|
|
|
|
|
|
class NewlineLinter(Linter):
|
|
|
|
msg = 'Contains DOS-style newlines'
|
2016-02-01 07:39:40 -07:00
|
|
|
# git supports newline conversion. Catch in CI, ignore on Windows.
|
|
|
|
ignore = os.linesep != '\n' and not os.environ.get('TRAVIS')
|
2015-02-14 17:59:17 -07:00
|
|
|
def check_line(self, line):
|
2016-02-01 07:39:40 -07:00
|
|
|
return '\r' not in line
|
2015-02-14 20:25:10 -07:00
|
|
|
def fix_line(self, line):
|
|
|
|
return line.replace('\r', '')
|
2015-02-14 17:59:17 -07:00
|
|
|
|
|
|
|
class TrailingWhitespaceLinter(Linter):
|
|
|
|
msg = 'Contains trailing whitespace'
|
|
|
|
def check_line(self, line):
|
2016-02-01 07:39:40 -07:00
|
|
|
line = line.replace('\r', '').replace('\n', '')
|
|
|
|
return not line.strip() or line == line.rstrip('\t ')
|
2015-02-14 20:25:10 -07:00
|
|
|
def fix_line(self, line):
|
|
|
|
return line.rstrip('\t ')
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2015-02-14 20:07:57 -07:00
|
|
|
class TabLinter(Linter):
|
|
|
|
msg = 'Contains tabs'
|
|
|
|
def check_line(self, line):
|
|
|
|
return '\t' not in line
|
2015-02-14 20:25:10 -07:00
|
|
|
def fix_line(self, line):
|
|
|
|
return line.replace('\t', ' ')
|
2015-02-14 20:07:57 -07:00
|
|
|
|
2016-02-01 07:39:40 -07:00
|
|
|
linters = [cls() for cls in Linter.__subclasses__() if not cls.ignore]
|
2015-02-14 20:07:57 -07:00
|
|
|
|
|
|
|
def main():
|
2020-06-29 21:58:47 -06:00
|
|
|
is_github_actions = os.environ.get('GITHUB_ACTIONS')
|
2015-02-14 20:07:57 -07:00
|
|
|
root_path = os.path.abspath(sys.argv[1] if len(sys.argv) > 1 else '.')
|
2015-02-21 21:06:50 -07:00
|
|
|
if not os.path.exists(root_path):
|
|
|
|
print('Nonexistent path: %s' % root_path)
|
|
|
|
sys.exit(2)
|
2015-02-14 20:25:10 -07:00
|
|
|
fix = (len(sys.argv) > 2 and sys.argv[2] == '--fix')
|
2015-02-14 20:13:10 -07:00
|
|
|
global path_blacklist
|
2015-04-06 09:25:30 -06:00
|
|
|
path_blacklist = list(map(lambda s: os.path.join(root_path, s.replace('^', '')) if s.startswith('^') else s, path_blacklist))
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2015-02-14 20:07:57 -07:00
|
|
|
for cur, dirnames, filenames in os.walk(root_path):
|
|
|
|
for filename in filenames:
|
|
|
|
full_path = os.path.join(cur, filename)
|
|
|
|
rel_path = full_path.replace(root_path, '.')
|
|
|
|
if not valid_file(full_path):
|
|
|
|
continue
|
2015-02-14 20:25:10 -07:00
|
|
|
lines = []
|
2015-02-14 20:07:57 -07:00
|
|
|
with open(full_path, 'rb') as f:
|
2015-04-06 09:25:30 -06:00
|
|
|
lines = f.read().split(b'\n')
|
|
|
|
for i, line in enumerate(lines):
|
|
|
|
try:
|
|
|
|
lines[i] = line.decode('utf-8')
|
|
|
|
except UnicodeDecodeError:
|
2020-06-29 21:58:47 -06:00
|
|
|
msg_params = (rel_path, i + 1, 'Invalid UTF-8 (other errors will be ignored)')
|
|
|
|
if is_github_actions:
|
|
|
|
error()
|
|
|
|
print('::error file=%s,line=%i::%s' % msg_params)
|
|
|
|
else:
|
|
|
|
error('%s:%i: %s' % msg_params)
|
2015-04-06 09:25:30 -06:00
|
|
|
lines[i] = ''
|
2015-02-14 20:25:10 -07:00
|
|
|
for linter in linters:
|
|
|
|
try:
|
|
|
|
linter.check(lines)
|
|
|
|
except LinterError as e:
|
2020-06-29 21:58:47 -06:00
|
|
|
if is_github_actions:
|
|
|
|
error()
|
|
|
|
print(e.github_actions_workflow_command(rel_path))
|
|
|
|
else:
|
|
|
|
error('%s: %s' % (rel_path, e))
|
2015-02-14 20:25:10 -07:00
|
|
|
if fix:
|
|
|
|
linter.fix(lines)
|
|
|
|
contents = '\n'.join(lines)
|
|
|
|
with open(full_path, 'wb') as f:
|
|
|
|
f.write(contents)
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2015-02-14 20:07:57 -07:00
|
|
|
if success:
|
|
|
|
print('All linters completed successfully')
|
|
|
|
sys.exit(0)
|
|
|
|
else:
|
|
|
|
sys.exit(1)
|
2015-02-14 17:59:17 -07:00
|
|
|
|
2015-02-14 20:07:57 -07:00
|
|
|
if __name__ == '__main__':
|
|
|
|
main()
|